MAAP staging: Define group shared folders volumes and volume mounts as dict #6102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging this PR will trigger the following deployment actions. Support deploymentsNo support upgrades will be triggered Staging deployments
Production deployments
|
sunu
force-pushed
the
maap-staging-group-shared-directories-2
branch
2 times, most recently
from
e218550 to
25eae5a
Compare
sunu
commented
May 27, 2025
| # so that the user can't see the contents of other groups' folders | ||
| # that the user is not a member of | ||
| name: shared-group-placeholder | ||
| mountPath: /home/jovyan/shared-group |
There was a problem hiding this comment.
Not sure if this the best approach to fix visibility of stale group shared folders. Please let me know if there's a better way to do this.
The concern is: If a user previously had a shared group folder mounted (e.g., to /home/jovyan/shared-group/<group-folder>), their underlying home PVC (<home-pvc>/<user>/) might now contain a persistent directory at shared-group/<group-folder> that was created by Kubernetes as a mount point.
Later, if the user is no longer in that group, the specific mount for the actual shared data is removed. However, the shared-group/<group-folder> directory within their personal PVC home will still be visible (as part of the main /home/jovyan mount). This can lead to confusion, showing outdated or empty folders for groups they no longer have access to.
sunu
force-pushed
the
maap-staging-group-shared-directories-2
branch
from
74a6779 to
e008806
Compare
|
Edit: I misread that -- |
|
@sunu hmm, can this be intentionally set to an empty object or something else to test? |
|
@yuvipanda yea, my bad, I misread the schema. |
2 tasks
The upstream JupyterHub Helm chart has added support for dict values for volumes and volume mounts in version 4.3.0. This allows us to easily override the config values we need to without having to specify the entire list again.
|
I've updated the PR to take advantage of support for dict values in z2jh 4.3.0. Converting to draft so that we don't merge it before #6915 is fixed and z2jh 4.3.0 is rolled out across all hubs. |
sunu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying out suggestions from #6010 (comment)Haven't tried this out live yet, because I'm having some trouble logging in to the MAAP staging hub.But if I understand correctly, we will run into issues without upstream changes because of howextraFilesis handled. This expects theKubeSpawner.volumesandKubeSpawner.volume_mountsto be lists. SimilarlyextraVolumes/extraVolumeMountshandling also expectsKubeSpawner.volumesandKubeSpawner.volume_mountsto be lists.I have tried this out on MAAP staging and it seems to work as expected.
related to NASA-IMPACT/veda-jupyterhub#66
Update
z2jh version 4.3.0 now supports dict based values for all supported fields and this PR now takes advantage of that. I've tested this on MAAP staging hub manually. But to merge this in, we need to wait for #6915 to roll out z2jh 4.3.0 for all hubs.